WHC/Hermit
1
0
Fork 1
Code Issues Pull Requests Actions Packages Projects Releases 12 Wiki Activity

ci: drop sanitizers job; harden test_subagent fake server
ci / linux (clang) (push) Failing after 2m58s
Details
ci / linux (gcc) (push) Failing after 3m27s
Details
ci / musl (push) Failing after 17s
Details
ci / windows-cross (push) Failing after 26s
Details

Browse Source 
test_subagent segfaulted in the Docker runner: the fake SSE handler took
user + strlen(user) - 1 with an empty user string. Guard JSON access and
format the child report with an empty-safe last character. Remove the
sanitizers job entirely (if: false still queued it and blocked the runner).
This commit is contained in:
WHC
2026-10-07 02:27:00 +08:00
parent e5ea869681
commit 420f9b242c
2 changed files with 23 additions and 41 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/test_subagent.c
+23 -10
View File
@@ -93,7 +93,7 @@ static void reply_calls(test_sock_t fd, const char *const *calls, int n) {
cJSON *tc = cJSON_AddArrayToObject(d, "tool_calls");
cJSON *c = cJSON_CreateObject();
cJSON_AddNumberToObject(c, "index", i);
char id[16];
char id[32];
snprintf(id, sizeof(id), "call_%d", i);
cJSON_AddStringToObject(c, "id", id);
cJSON_AddStringToObject(c, "type", "function");
@@ -120,19 +120,30 @@ static int has_tool(const cJSON *body, const char *name) {
static void handle(test_sock_t fd, const char *body_txt) {
cJSON *body = cJSON_Parse(body_txt);
if (!body) {
const char *err = "HTTP/1.1 400 Bad Request\r\nConnection: close\r\n\r\n";
send_all(fd, err, strlen(err));
return;
}
const cJSON *msgs = cJSON_GetObjectItemCaseSensitive(body, "messages");
int nm = cJSON_GetArraySize(msgs);
const cJSON *sys = cJSON_GetObjectItemCaseSensitive(
cJSON_GetArrayItem(msgs, 0), "content");
const cJSON *last = cJSON_GetArrayItem(msgs, nm - 1);
const char *last_role =
cJSON_GetObjectItemCaseSensitive(last, "role")->valuestring;
int nm = cJSON_IsArray(msgs) ? cJSON_GetArraySize(msgs) : 0;
const cJSON *sys = NULL;
const char *last_role = "";
const char *user = "";
if (nm > 0) {
sys = cJSON_GetObjectItemCaseSensitive(cJSON_GetArrayItem(msgs, 0),
"content");
const cJSON *last = cJSON_GetArrayItem(msgs, nm - 1);
const cJSON *lr = cJSON_GetObjectItemCaseSensitive(last, "role");
if (cJSON_IsString(lr))
last_role = lr->valuestring;
}
for (int i = 0; i < nm; i++) {
const cJSON *m = cJSON_GetArrayItem(msgs, i);
const cJSON *r = cJSON_GetObjectItemCaseSensitive(m, "role");
const cJSON *c = cJSON_GetObjectItemCaseSensitive(m, "content");
if (strcmp(r->valuestring, "user") == 0 && cJSON_IsString(c))
if (cJSON_IsString(r) && strcmp(r->valuestring, "user") == 0 &&
cJSON_IsString(c))
user = c->valuestring;
}
const char *hdr = "HTTP/1.1 200 OK\r\nContent-Type: text/event-stream\r\n"
@@ -160,8 +171,10 @@ static void handle(test_sock_t fd, const char *body_txt) {
const char *calls[] = {"read_file", "{\"path\":\"a.txt\"}"};
reply_calls(fd, calls, 1);
} else {
char out[256];
snprintf(out, sizeof(out), "child report %s", user + strlen(user) - 1);
/* last char of the user prompt (e.g. "Find A" -> "A"); empty-safe */
char tag = user[0] ? user[strlen(user) - 1] : '?';
char out[64];
snprintf(out, sizeof(out), "child report %c", tag);
reply_text(fd, out);
}
atomic_fetch_sub(&g_child_active, 1);